Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched Bokeh LineAnnotationPlot to use Span annotation #537

Merged
merged 1 commit into from Sep 23, 2016
Merged

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Mar 6, 2016

Previously we had to use the bokeh BoxAnnotation to render VLine and HLine Elements but since 0.11 bokeh ships with a Span annotation which is more appropriate. This can be merged once bokeh/bokeh#3993 in bokeh is fixed and 0.12 is released.

@philippjfr philippjfr force-pushed the bokeh_span branch from b08be9f to 7f6db14 Sep 16, 2016
@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Sep 23, 2016

Ready to merge now, we don't support bokeh <0.12 anymore anyway.

@jbednar jbednar merged commit 01c66c6 into master Sep 23, 2016
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on bokeh_span at 71.998%
Details
@philippjfr
s3-reference-data-cache Tests passing no test data changes required.
Details
@jbednar jbednar deleted the bokeh_span branch Sep 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants