Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renderer instances keep track of last plot #538

Merged
merged 1 commit into from Mar 11, 2016
Merged

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Mar 6, 2016

This PR adds a last_plot attribute to Renderer instances, which let's the user easily get a handle on the last thing they plotted, which is very helpful for debugging, understanding how plots are structured, and in order to directly customize a plot, e.g. to prototype an initial_hook or final_hook.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Mar 6, 2016

As we've discussed, Renderer is the right place to put this and it is a small change. I would be happy to merge but I'm wondering what is up with Travis right now...

@philippjfr philippjfr force-pushed the renderer_last_plot branch from 4a67851 to dcee812 Mar 11, 2016
@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Mar 11, 2016

Restarted the tests, ready to merge when it goes green.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Mar 11, 2016

Tests are passing. Merging.

jlstevens added a commit that referenced this pull request Mar 11, 2016
Renderer instances keep track of last plot
@jlstevens jlstevens merged commit 3d19cfc into master Mar 11, 2016
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on renderer_last_plot at 69.294%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the renderer_last_plot branch Apr 1, 2016
@philippjfr philippjfr added this to the v1.5.0 milestone Apr 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants