Don't disable Jedi completion by default #5701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hoxbro
changed the title
Codecov Report
@@ Coverage Diff @@
## main #5701 +/- ##
==========================================
- Coverage 88.30% 88.30% -0.01%
==========================================
Files 302 302
Lines 62603 62603
==========================================
- Hits 55281 55279 -2
- Misses 7322 7324 +2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jlstevens
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2132 (comment)
This change means we don't inject
ip.run_line_magic('config', 'IPCompleter.use_jedi = False')into the notebook.The original problem described in the issue had already been fixed previously. Though, I added quotations around the unmatched arguments in this PR.