Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Store.add_style_opts #587

Merged
merged 1 commit into from Apr 11, 2016
Merged

Fixed Store.add_style_opts #587

merged 1 commit into from Apr 11, 2016

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Mar 31, 2016

Small fix for Store.add_style_opts which was not correctly getting the class name you were adding the style option for because type(component).__name__ == 'ParameterizedMetaclass'.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Mar 31, 2016

Seems fine although I'm sure this was tested in the past and worked fine at that point. Happy to merge once the tests pass.

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Apr 10, 2016

Ready to merge.

@jlstevens jlstevens merged commit cd5858a into master Apr 11, 2016
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on add_style_opts at 69.559%
Details
@philippjfr
s3-reference-data-cache Tests passing no test data changes required.
Details
@philippjfr philippjfr deleted the add_style_opts branch Apr 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants