Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Raster.reduce for non Image types #672

Merged
merged 1 commit into from May 11, 2016
Merged

Fixed Raster.reduce for non Image types #672

merged 1 commit into from May 11, 2016

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented May 11, 2016

Fix for #595, handles the reduction of the x-axis for the Raster class itself correctly. The reduce method is currently shared between all Raster and Image classes and it only handled the Image case correctly. In future when we have integrated Raster types with the grid interfaces this should be refactored but it works fine for now.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented May 11, 2016

In future when we have integrated Raster types with the grid interfaces this should be refactored but it works fine for now.

It might be worth mentioning this in a comment as a reminder.

Otherwise looks fine, the pr build is passing and I'm happy to merge.

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented May 11, 2016

Not sure it needs a reminder, we will be forced to refactor these methods when they become part of an interface anyway.

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented May 11, 2016

Ready to merge, PR build passed.

@jlstevens jlstevens merged commit 977c557 into master May 11, 2016
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.009%) to 69.79%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the raster_reduce branch May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants