Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dependency optional #792

Merged
merged 1 commit into from Jul 25, 2016
Merged

Make dependency optional #792

merged 1 commit into from Jul 25, 2016

Conversation

@tinloaf
Copy link
Contributor

@tinloaf tinloaf commented Jul 18, 2016

The DFrame -> TablePlot association should only be registered if there is a DFrame to be imported...

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Jul 18, 2016

Looks good to me!

I won't merge until Philipp also gives his feedback...

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Jul 25, 2016

Looks good, thanks for the fix!

@philippjfr philippjfr merged commit e8001b7 into holoviz:master Jul 25, 2016
2 of 3 checks passed
2 of 3 checks passed
@philippjfr
s3-reference-data-cache Tests still building.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.001%) to 69.428%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants