Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that NdOverlay is propagated correctly in dynamic batched mode #814

Merged
merged 2 commits into from Aug 16, 2016

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Aug 16, 2016

When an OverlayPlot is used in dynamic mode it is responsible for delegating the layers in the Overlay/NdOverlay to the appropriate subplots. This handling works fine when each layer in an NdOverlay is assigned its own plot (as is the case in regular non-batched mode), what was missing was handling for dynamic mode + batched mode in which case it just passes the whole NdOverlay to the subplot. This PR makes sure that happens.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Aug 16, 2016

Happy to merge although I would like to have tests for this sort of thing once we have the Bokeh testing infrastructure in place...

@jlstevens jlstevens merged commit fa43fa1 into master Aug 16, 2016
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.004%) to 46.695%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the dynamic_batched_overlay_fix branch Sep 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants