Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug computing extents of mpl SpreadPlot #821

Merged
merged 1 commit into from Aug 18, 2016
Merged

Fixed bug computing extents of mpl SpreadPlot #821

merged 1 commit into from Aug 18, 2016

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Aug 18, 2016

The extent of Spread Elements wasn't being correctly computed in matplotlib. This provides a safe (but not perfect) implementation, computing the absolute largest possible extent, because there is no direct way to compute it precisely across multiple frames at the moment, something that will only become possible when we make the normalization system more general.

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Aug 18, 2016

Reviewed the updated test date, rebuilding now. Then ready to merge.

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Aug 18, 2016

Had to rebuild the test data hence why the push build is failing. Otherwise ready to merge.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Aug 18, 2016

Looks good! Merging.

@jlstevens jlstevens merged commit a8bce95 into master Aug 18, 2016
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.03%) to 46.722%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the spread_extent branch Sep 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants