Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed Stream.value to 'contents' to avoid name clashes #845

Merged
merged 2 commits into from Sep 2, 2016

Conversation

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Sep 2, 2016

A parameter called value would be very natural to use in a stream making it likely to clash with the value property. Renaming this property to contents should help avoid potential name clashes and confusion.

Ready to merge.

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Sep 2, 2016

Looks good, contents is much less likely to clash than value. I'll merge when tests pass.

@jlstevens
Copy link
Contributor Author

@jlstevens jlstevens commented Sep 2, 2016

Push build has passed. I had to restart one of the pr builds due to a transient error - you can wait for that to pass but I don't think you need to!

@philippjfr philippjfr merged commit ce1ed4c into master Sep 2, 2016
2 of 4 checks passed
2 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
coverage/coveralls Coverage pending from Coveralls.io
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@jlstevens jlstevens deleted the stream_contents_rename branch Sep 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants