Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed caching of Table values #850

Merged
merged 5 commits into from Sep 7, 2016
Merged

Removed caching of Table values #850

merged 5 commits into from Sep 7, 2016

Conversation

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Sep 7, 2016

This PR allows Tables to be updated with streams by disabling the caching of cell values in TablePlot. I've tested that streams now work but I won't be confident that everything is working as it should until the tests pass.

@jlstevens
Copy link
Contributor Author

@jlstevens jlstevens commented Sep 7, 2016

One consequence of using streams is that it isn't possible for TablePlot to adjust the size of the table based on future (unknown) values. This will always be an issue using DynamicMap so I only want to point out this problem as I'm not sure how it can be solved.

@@ -117,7 +115,7 @@ def initialize_plot(self, ranges=None):
for col in range(element.cols):
if summarize and row > half_rows:
adjusted_row = (element.rows - self.max_rows + row)
cell_value = self.cell_values[self.keys[-1]][(row, col)]
cell_value = element.pprint_cell(row, col)

This comment has been minimized.

@philippjfr

philippjfr Sep 7, 2016
Member

Shouldn't both of these calls also pass the return value through the pprint_value method on TablePlot, I'm not sure why both the element and the plot need a pprint method but I assume there was a reason.

This comment has been minimized.

@jlstevens

jlstevens Sep 7, 2016
Author Contributor

Well spotted! I've just pushed a commit to fix this.

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Sep 7, 2016

Looks good now. Happy to merge when tests pass.

@philippjfr philippjfr merged commit 24d1137 into master Sep 7, 2016
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.1%) to 69.193%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the table_update_fix branch Sep 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants