Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed python3 bug in GenericOverlayPlot #856

Merged
merged 2 commits into from Sep 11, 2016
Merged

Fixed python3 bug in GenericOverlayPlot #856

merged 2 commits into from Sep 11, 2016

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Sep 11, 2016

Simple python3 bug causing batched plotting to fail in python3.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Sep 11, 2016

Looks like a very straightforward fix and I'll merge as soon as the tests pass.

My only other suggestion is to write some unit tests so we can detect such problems earlier in future.

@jlstevens jlstevens merged commit 27903d8 into master Sep 11, 2016
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+1.7%) to 71.055%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the extent_py3_fix branch Sep 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants