Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched to python initiated JupyterComm for mpl #864

Merged
merged 2 commits into from Sep 17, 2016
Merged

Switched to python initiated JupyterComm for mpl #864

merged 2 commits into from Sep 17, 2016

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Sep 16, 2016

Renamed JupyterPushComm to JupyterComm and used it for matplotlib. Avoids errors when Comm is not initialized in time when running through a notebook quickly.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Sep 16, 2016

Thanks for implementing the name change and hopefully, 'Run All' will now work properly again!

Ready to merge?

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Sep 16, 2016

Yes, go ahead (after the tests pass).

@jlstevens jlstevens merged commit f315ef8 into master Sep 17, 2016
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on mpl_comms at 71.98%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the mpl_comms branch Oct 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants