Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipping archive.add in display_hooks for FileArchives #865

Merged
merged 1 commit into from Sep 19, 2016
Merged

Conversation

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Sep 16, 2016

Small PR designed to address #836.

@jlstevens
Copy link
Contributor Author

@jlstevens jlstevens commented Sep 19, 2016

Ready to merge...the tests failed for a reason that has now been addressed on master.

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Sep 19, 2016

Looks fine and will pass on master. Merging.

@philippjfr philippjfr merged commit a026943 into master Sep 19, 2016
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@jlstevens
Copy link
Contributor Author

@jlstevens jlstevens commented Sep 19, 2016

Thanks!

@philippjfr philippjfr deleted the nbarchive_skip branch Sep 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants