Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matplotlib2.0.0b4 compatibility fix (1/2) #868

Merged
merged 1 commit into from Sep 19, 2016
Merged

matplotlib2.0.0b4 compatibility fix (1/2) #868

merged 1 commit into from Sep 19, 2016

Conversation

@stonebig
Copy link
Contributor

@stonebig stonebig commented Sep 18, 2016

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Sep 18, 2016

This PR looks like it might be redundant with #867 (which seems more complete as it isn't missing some of the necessary imports).

@stonebig
Copy link
Contributor Author

@stonebig stonebig commented Sep 19, 2016

it's not the same file. whith github interface, you modify on file at a time

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Sep 19, 2016

Same as #867, tests failing due to anaconda pyqt issues. Going to merge and then fix the tests with #871.

@philippjfr philippjfr merged commit e8600c7 into holoviz:master Sep 19, 2016
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@philippjfr
s3-reference-data-cache Tests still building.
Details
@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Sep 19, 2016

it's not the same file. whith github interface, you modify on file at a time

Ah, I see. Fairly awkward to have to build PRs that way! :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants