Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed updating of colormappers #893

Merged
merged 1 commit into from Sep 30, 2016
Merged

Fixed updating of colormappers #893

merged 1 commit into from Sep 30, 2016

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Sep 30, 2016

The way color mappers were updated was a bit hacky and in fact didn't work in some cases. This ensures existing color mapper instances are simply updated.

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Sep 30, 2016

Ready to merge when tests pass (there are bokeh colormapper tests).

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Sep 30, 2016

Looks good. Merging.

@jlstevens jlstevens merged commit c12226c into master Sep 30, 2016
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on colormapping_fix at 73.418%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the colormapping_fix branch Oct 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants