Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes for widgets #897

Merged
merged 1 commit into from Oct 5, 2016
Merged

Small fixes for widgets #897

merged 1 commit into from Oct 5, 2016

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Oct 5, 2016

Two small fixes for widgets to process 'Complete' acknowledgements in python3 and to handle DynamicMaps with zero-kdims.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Oct 5, 2016

Is this a different message from 'Ready'? Or are we still planning to change the 'Complete' message to 'Ready'?

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Oct 5, 2016

We'll switch from Ready to Complete in the widgets once we implement the widget manager.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Oct 5, 2016

Ok then. Merging.

@jlstevens jlstevens merged commit 69def13 into master Oct 5, 2016
0 of 3 checks passed
0 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
coverage/coveralls Coverage pending from Coveralls.io
Details
@philippjfr philippjfr deleted the widget_fixes branch Oct 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants