Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed empty NdOverlay on initialization in batched mode #902

Merged
merged 2 commits into from Oct 5, 2016

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Oct 5, 2016

Previously some parts of the plotting code would receive empty NdOverlays on initialization causing it to break. Now the plot is initialized on the last non-empty frame. Since the plot is updated subsequently with the correct frame this should not cause any issues.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Oct 5, 2016

Tests have passed. Merging.

@jlstevens jlstevens merged commit 2be0aa2 into master Oct 5, 2016
3 of 4 checks passed
3 of 4 checks passed
coverage/coveralls Coverage pending from Coveralls.io
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@jbednar jbednar deleted the empty_overlay_batched branch Oct 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants