Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added downsample_columns operation #903

Merged
merged 4 commits into from Oct 5, 2016
Merged

Added downsample_columns operation #903

merged 4 commits into from Oct 5, 2016

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Oct 5, 2016

No description provided.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Oct 5, 2016

Looks good and I am much happier with the new name. Merging.

Loading

@jlstevens jlstevens merged commit 47b5582 into master Oct 5, 2016
0 of 2 checks passed
Loading
@philippjfr philippjfr deleted the downsample_operation branch Oct 14, 2016
jbednar
Copy link
Member

jbednar commented on 5f20ea5 Apr 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@philippjfr, where is plot supposed to be defined? This line is raising an error on current code using decimate, and I can't see how it could ever work.

Loading

philippjfr
Copy link
Member

philippjfr commented on 5f20ea5 Apr 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, should be element.

Loading

jbednar
Copy link
Member

jbednar commented on 5f20ea5 Apr 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please test that? I already tried using element by adding decimate(points) to the end of census-hv.ipynb, but that didn't work for me either.

Loading

philippjfr
Copy link
Member

philippjfr commented on 5f20ea5 Apr 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you using a dask dataframe?

Loading

jbednar
Copy link
Member

jbednar commented on 5f20ea5 Apr 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Loading

jbednar
Copy link
Member

jbednar commented on 5f20ea5 Apr 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants