Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple streams attached to the same plot model #904

Merged
merged 3 commits into from Oct 5, 2016
Merged

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Oct 5, 2016

Currently when multiple streams are attached to the same plot model they will override each other. This PR ensures that either the python callback or the JS callback are merged depending on whether the callback is of the same type. This is mostly a problem if two separate plots attach distinct streams to a set of linked axes. It also includes a fix for Layouts with multiple streams of the same type across the subplots, which would previously complain about parameter overlap. Finally it allows supplying stream instances to operations instead of instantiating a Stream instance internally, which can be useful to get a handle on the stream.

Here's a demo:

points = hv.Points(np.random.multivariate_normal((0,0), [[0.1, 0.1], [0.1, 1.0]], (1000000,)))
Datashade(points) + decimate(points)

linked_datadecimate

@jbednar
Copy link
Member

@jbednar jbednar commented Oct 5, 2016

It certainly looks and sounds good!

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Oct 5, 2016

Looks good. Merging.

@jlstevens jlstevens merged commit 8e14bbb into master Oct 5, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on linked_streams at 72.655%
Details
@philippjfr philippjfr deleted the linked_streams branch Oct 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants