Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard comms fixes #912

Merged
merged 3 commits into from Oct 7, 2016
Merged

Dashboard comms fixes #912

merged 3 commits into from Oct 7, 2016

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Oct 7, 2016

A fix to get streams working on Jupyter dashboards and another fix to ensure events are processed when an error is received.

@philippjfr philippjfr force-pushed the dashboard_comms_fixes branch from 8659eb4 to f1a7e99 Oct 7, 2016
@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Oct 7, 2016

Great - though I assume we still need to use a dev version of ipywidgets for the dashboard comms to work?

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Oct 7, 2016

Great - though I assume we still need to use a dev version of ipywidgets for the dashboard comms to work?

Yes, I also remembered you have to satisfy the missing jQuery dependency. We'll be able to expose that in the notebook_extension though.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Oct 7, 2016

Thanks for clarifying. Ready to merge?

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Oct 7, 2016

Yep

@jlstevens jlstevens merged commit 4b4f577 into master Oct 7, 2016
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 72.842%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@jbednar jbednar deleted the dashboard_comms_fixes branch Oct 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants