Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed extra copies of options in messages #932

Merged
merged 2 commits into from Oct 18, 2016
Merged

Removed extra copies of options in messages #932

merged 2 commits into from Oct 18, 2016

Conversation

@jbednar
Copy link
Member

@jbednar jbednar commented Oct 14, 2016

RIght now, if you try to set an option with an invalid name, you get a huge list of all options, with three copies of everything. There's probably a way to avoid having three copies, and if anyone wants to track that down, feel free! Otherwise, we could merge this PR and at least make the messages easier to understand.

@jbednar
Copy link
Member Author

@jbednar jbednar commented Oct 14, 2016

The test failures look unrelated to this change, and related to ContinuumIO/anaconda-issues#1068

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Oct 14, 2016

The fix looks good and the test failures are annoying.

My only suggestion is that maybe it would be good to sort the set of keywords alphabetically?

@jbednar
Copy link
Member Author

@jbednar jbednar commented Oct 14, 2016

Ok, sorted (pun intended). I'm actually not sure how to trigger this message anymore, though, as I only saw it with parameter misspellings combined with various combinations of packages (param, jupyter, etc.) that were installed when I wrote the PR, and those are long gone. It's hard to see how this would fail, but I do have to admit that I haven't tested it.

@philippjfr philippjfr force-pushed the options-warning branch from 93bf018 to 86bff61 Oct 18, 2016
@philippjfr
Copy link
Member

@philippjfr philippjfr commented Oct 18, 2016

Looks good and tests passed. Merging.

@philippjfr philippjfr merged commit f1645d0 into master Oct 18, 2016
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on options-warning at 72.958%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@jbednar jbednar deleted the options-warning branch Oct 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants