Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset range fix #938

Merged
merged 4 commits into from Oct 18, 2016
Merged

Dataset range fix #938

merged 4 commits into from Oct 18, 2016

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Oct 18, 2016

The Dataset.range method was not correctly processing one-sided fixed ranges, e.g. a Dimension with range=(0, None) would override the actual upper-bound with None, rather than letting it auto-compute the part of the range that is unspecified. This PR fixes this issue and adds a small fix for computing the correct extents on SpikesPlots.

@philippjfr philippjfr force-pushed the dataset_range_fix branch from 489a3cd to 8b7ee8c Oct 18, 2016
@jbednar jbednar merged commit 5a5a731 into master Oct 18, 2016
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.001%) to 72.958%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@jbednar jbednar deleted the dataset_range_fix branch Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants