Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensured Dimensioned.range respects one-sided Dimension.range #940

Merged
merged 1 commit into from Oct 18, 2016

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Oct 18, 2016

After just fixing one-sided Dimension.range specifications on Dataset types I just noticed that Dimensioned itself does not handle this condition correctly either. This ensures handling for ranges which are None on either side are handled correctly.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Oct 18, 2016

Good to have spotted the issue in both places. Merging.

@jlstevens jlstevens merged commit 30f1237 into master Oct 18, 2016
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.01%) to 72.949%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the dimension_range_fix branch Jan 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants