Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added perceptually uniform fire colormap #943

Merged
merged 4 commits into from Oct 21, 2016
Merged

Added perceptually uniform fire colormap #943

merged 4 commits into from Oct 21, 2016

Conversation

@jbednar
Copy link
Member

@jbednar jbednar commented Oct 20, 2016

The "hot" colormap that is the default for Image and other Raster types in Holoviews is highly perceptually nonuniform, which makes strange artifacts and makes it difficult to interpret data:

image

On my request, Peter Kovesi created a much better version he called linear_kryw_0_100_c71 (see http://peterkovesi.com/projects/colourmaps):

image

The new colormap (left) gives much smoother images that more faithfully represent the data:

image

This PR adds the new colormap, renamed "fire" for simplicity and to indicate the similarity to "hot". A subsequent PR should change the default colormap to "fire".

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Oct 20, 2016

Looks good!

I'm just wondering if the formatting of the triples might look nicer if you aligned all the closing square brackets...

@jlstevens jlstevens added this to the v1.7.0 milestone Oct 20, 2016
@jbednar
Copy link
Member Author

@jbednar jbednar commented Oct 20, 2016

Ok, reformatted as suggested.

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Oct 21, 2016

Looks good to me! For now matplotlib colormaps are used everywhere so you'll be able to reference it by name. In future we can decouple matplotlib colormaps from bokeh and switch from hot to fire in our defaults.

@philippjfr philippjfr merged commit 517e481 into master Oct 21, 2016
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.004%) to 75.741%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@jbednar jbednar deleted the fire branch Oct 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants