Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapping types complain when supplied with vdims #950

Merged
merged 1 commit into from Oct 24, 2016
Merged

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Oct 24, 2016

As suggested in #811, NdMapping types will now error when you supply any value dimensions (vdims).

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Oct 24, 2016

Hopefully this will help avoid confusion. Merging.

@jlstevens jlstevens merged commit 81dc19f into master Oct 24, 2016
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.001%) to 75.749%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the ndmapping_vdims_error branch Jan 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants