Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed confusing aliasing #956

Merged
merged 1 commit into from Oct 27, 2016
Merged

Fixed confusing aliasing #956

merged 1 commit into from Oct 27, 2016

Conversation

@jbednar
Copy link
Member

@jbednar jbednar commented Oct 27, 2016

The attribute "colors" was being used in the same function both to refer to the matplotlib colors module and to a local dictionary. In some cases (not easily reproducible) this led to complaints about variables being referenced before they were assigned. In any case this change makes it much clearer what is meant by "colors" each time.

@jbednar
Copy link
Member Author

@jbednar jbednar commented Oct 27, 2016

The tests failed for Python3, but that seems to be unrelated to this PR, as it's a failure in a bokeh file and this is a change to the mpl backend.

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Oct 27, 2016

Looks fine, thanks for the fix. The test failure was a transient issue in the bokeh backend.

@philippjfr philippjfr merged commit 8d6b2a1 into master Oct 27, 2016
3 of 4 checks passed
@jbednar jbednar deleted the colors_fix branch Oct 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants