Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure OverlayPlot ranges are computed correctly when +axiswise, +framewise #970

Merged
merged 1 commit into from Nov 4, 2016

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Nov 4, 2016

Previously the compute_ranges method would skip computing the ranges for Elements in an OverlayPlot when both +axiswise and +framewise were active.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Nov 4, 2016

The tests have passed and the change makes sense to me.

I believe this partially addresses the normalization problem mentioned in #965. Merging.

@jlstevens jlstevens merged commit 71ca68e into master Nov 4, 2016
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 75.715%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the axiswise_overlay branch Dec 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants