Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow customizing legend position #119

Merged
merged 1 commit into from Nov 29, 2018
Merged

Allow customizing legend position #119

merged 1 commit into from Nov 29, 2018

Conversation

philippjfr
Copy link
Member

The legend option now allows either True/False (keeping current behavior) or a valid holoviews legend_position.

Any thoughts @jsignell? I prefer this to introducing a separate legend_position option but you might have a different preference.

jsignell
jsignell approved these changes Nov 29, 2018
View reviewed changes
Copy link
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Mimics the behavior of toolbar I think. The only thing would be whether we want it to be position or None rather than position or True.

@philippjfr philippjfr merged commit 9ee63d2 into master Nov 29, 2018
@set92 set92 mentioned this pull request Jan 15, 2019
Closed
@philippjfr philippjfr deleted the legend_position branch May 1, 2020 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsignell jsignell jsignell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@philippjfr @jsignell