Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support string projection kwd #372

merged 3 commits into from Nov 14, 2020

Support string projection kwd #372

merged 3 commits into from Nov 14, 2020


Copy link

@ahuang11 ahuang11 commented Nov 13, 2019

As jsignell suggested, string crs probably isn't too useful since you need to pass arguments in most cases if it's not degree latitude/longitude crs so I didn't support that, but I think being able to use a simple string for projection is useful.


if projection in all_crs and projection != 'GOOGLE_MERCATOR':
projection = getattr(ccrs, projection)()
elif projection == 'GOOGLE_MERCATOR':
projection = getattr(ccrs, projection)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite know what's happening with GOOGLE_MERCATOR here. Could it maybe be handled by checking if it's callable, and only calling callable things?

@philippjfr philippjfr merged commit c371bd9 into master Nov 14, 2020
@maximlt maximlt deleted the string_projection branch November 18, 2021 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants