Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add keyword fontscale (solving #395) #397

Merged
merged 3 commits into from Jan 24, 2020

Conversation

SandervandenOord
Copy link
Contributor

Fontscale keyword was added so that hvplot can also handle this keyword. This should solve #395 .

Also added documentation about fontscale in docstring of class HoloViewsConverter(object).

I didn't add fontscale to the init() of class HoloViewsConverter(object), but it falls now under the **kwds. If this still needs to be done, please let me know.

Tested some simple plots myself in Jupyter, that seemed to work. Didn't add any formal tests.

hvplot/converter.py Outdated Show resolved Hide resolved
@philippjfr
Copy link
Member

Thanks! Not sure what's up with that test. Will have to look at it.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.338% when pulling f4f400f on SandervandenOord:fontscale_add into 1c76c1f on holoviz:master.

@philippjfr philippjfr merged commit 856ee5e into holoviz:master Jan 24, 2020
@philippjfr
Copy link
Member

Thanks @SandervandenOord!

@SandervandenOord SandervandenOord deleted the fontscale_add branch January 24, 2020 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants