add keyword fontscale (solving #395)#397
Merged
philippjfr merged 3 commits intoholoviz:masterfrom Jan 24, 2020
Merged
Conversation
philippjfr
reviewed
Jan 10, 2020
Member
|
Thanks! Not sure what's up with that test. Will have to look at it. |
Member
|
Thanks @SandervandenOord! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fontscale keyword was added so that hvplot can also handle this keyword. This should solve #395 .
Also added documentation about fontscale in docstring of class HoloViewsConverter(object).
I didn't add fontscale to the init() of class HoloViewsConverter(object), but it falls now under the **kwds. If this still needs to be done, please let me know.
Tested some simple plots myself in Jupyter, that seemed to work. Didn't add any formal tests.