Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support setting options for diagonal plots in scatter_matrix #602

Merged
merged 3 commits into from
May 21, 2021

Conversation

toddrjen
Copy link
Contributor

This adds a new argument that allows the user to specify keyword arguments for the diagonal plots in hvplot.plotting.scatter_matrix. Fixes #599.

Copy link
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Should we consider also supporting the Pandas hist_kwds by code like if hist_kwds in kwds: diagonal_kwds=kwds.pop('hist_kwds')? The only reason to do so is if some specific hist_kwds that are valid in Pandas .plot would then be accepted here. If the actual options differ as well, then there'd be no point...

@toddrjen
Copy link
Contributor Author

Alright, I added support for both hist_kwds and density_kwds. I also added support for specifying a colormap, which is currently hard-coded and cannot be overridden. The current colormap is okay for chart='scatter' but not good for other chart types.

@toddrjen
Copy link
Contributor Author

toddrjen commented May 4, 2021

The test failures don't seem to be related to this PR. Is there anything else anyone thinks I should change?

@philippjfr philippjfr merged commit 1843949 into holoviz:master May 21, 2021
@philippjfr
Copy link
Member

Thanks @toddrjen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow specifying keyword arguments for diagonal
3 participants