Update the default internal value of clim to support Matplotlib#679
Conversation
|
Ok so my first attempt to solve this made the test suite fail :/ In the second and successful attempt, at least in light of the test suite, the |
|
It's working well with the matplotlib backend! |
|
I think I've finally found an acceptable solution but let me know what you think about it. It happens that what was done in #587, i.e. setting the So I've removed the line added by #587, and replaced it by a |
PR in preparation of the upcoming support of Matplotlib and Plotly.
self._dim_ranges['c']was set to eitherclimif not None or to(None, None). This caused no issue with the Bokeh backend of holoviews, which accepts aparam.Tupleforclimand handles properly when it includesNone. However both the Matplotlib and Plotly backends accept aparam.NumericTupleonly.The Bokeh backend used to accept a
param.NumericTupleonly as well, but that was changed in holoviz/holoviews#4383. The right fix might be to add support to whatever the Bokeh backend supports to Matplotlib & Plotly with allowing them to accept a non-numeric tuple forclim, but since I don't know what exactly this PR was about I went for the simpler, and hopefully correct, solution.An important question here would be, does the bokeh backend behave the same way when
climis set to(None, None)compared to(np.nan, np.nan)?@jlstevens pinging you since we talked about it briefly already 🙃