MAINT: Drop support for py2.7, min supported version is py3.6 now #702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Thanks for dropping Python 2 support (finally!) As for dropping 3.6 right now, I do think that is too aggressive. I do know various projects are also aggressively dropping support within the 3.x series but I also think there are still plenty of users still using python 3.6... Edit: Are there any 3.7 specific syntax changes here? I assume the syntax changes here (e.g. f-strings) are also fine with 3.6... |
Contributor
Author
|
The syntax should be fine with 3.6 too. |
MridulS
changed the title
Collaborator
|
Thanks! Once the tests pass, I think it looks good to merge! |
Member
|
Great thanks for updating it @MridulS , merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went a bit aggressive with dropping older python version support 😅
This PR makes 3.7 the min supported version.
Is this reasonable?
The test pipelines do not work with 3.8, 3.9 and 3.10 (#701) but I think the code itself should work.