Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Drop support for py2.7, min supported version is py3.6 now #702

Merged
merged 4 commits into from
Jan 31, 2022

Conversation

MridulS
Copy link
Contributor

@MridulS MridulS commented Jan 26, 2022

I went a bit aggressive with dropping older python version support 馃槄
This PR makes 3.7 the min supported version.

Is this reasonable?

The test pipelines do not work with 3.8, 3.9 and 3.10 (#701) but I think the code itself should work.

@coveralls
Copy link

coveralls commented Jan 26, 2022

Coverage Status

Coverage increased (+0.03%) to 70.439% when pulling d351010 on MridulS:pyup3.7 into 7864275 on holoviz:master.

@jlstevens
Copy link
Collaborator

jlstevens commented Jan 27, 2022

Is this reasonable?

Thanks for dropping Python 2 support (finally!)

As for dropping 3.6 right now, I do think that is too aggressive. I do know various projects are also aggressively dropping support within the 3.x series but I also think there are still plenty of users still using python 3.6...

Edit: Are there any 3.7 specific syntax changes here? I assume the syntax changes here (e.g. f-strings) are also fine with 3.6...

@MridulS
Copy link
Contributor Author

MridulS commented Jan 31, 2022

The syntax should be fine with 3.6 too.

@MridulS MridulS changed the title MAINT: Drop support for py2.7, min supported version is py3.7 now MAINT: Drop support for py2.7, min supported version is py3.6 now Jan 31, 2022
@jlstevens
Copy link
Collaborator

Thanks!

Once the tests pass, I think it looks good to merge!

@maximlt
Copy link
Member

maximlt commented Jan 31, 2022

Great thanks for updating it @MridulS , merging!

@maximlt maximlt merged commit 422e38f into holoviz:master Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants