Make rescale_discrete_levels a plot option#758
Merged
Conversation
jbednar
approved these changes
May 26, 2022
Member
jbednar
left a comment
There was a problem hiding this comment.
Thanks. I think this is ready to merge, along with the corresponding HoloViews PR.
philippjfr
reviewed
May 26, 2022
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was a datashader operation option, it's now a plot option that has no default value, like
cnorm.I assumed holoviz/holoviews#5268 would be merged, setting
rescale_discrete_levelstoTrueby default in theshaderoperation. If not, and if the intent is to have it set by default toTruein hvPlot but not in HoloViews (I'd prefer them having the same default), this PR will have to be adapted.