-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more tests to Interactive
and some comments
#812
Conversation
Ah I realized that part of the PR that implemented the support for functions as input to
Which I believe is the one that led to an increase of calls to |
This PR doesn't touch any code of Anyway this is better than before, and it has allowed me to better understand how |
This PR adds various tests to
Interactive
. The aim of these tests is two-fold: cover parts that were untested and better track the underlying logic ofInteractive
. More comments in particular are meant to be added.Interestingly I wrote these tests first based on the
0.7.3
version of hvPlot, before the support for functions as input was added. The logic at the time was slightly easier to comprehend. When writing the tests I added some utility to inspect calls to the_clone
method at it seemed central to the wayInteractive
operates. When I finally ran the tests against master I had to update these tests,_clone
is called more than it used too. The logic ofInteractive
has become more difficult to track.