Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes to the operators implemented by Interactive #814

Merged
merged 5 commits into from
Aug 5, 2022

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Aug 3, 2022

This PR fixes some issues observed on the operators implemented by Interactive:

  • reversed operators were implemented but the reverse info was never passed to the dim transform
  • one dunder method was using the wrong operator
  • removed __div__ as it has been removed in Python 3

This PR also makes the test suite fail when an xfail test actually passes (xpass).

@maximlt maximlt requested a review from hoxbro August 3, 2022 12:26
@maximlt maximlt merged commit 5f77d2c into master Aug 5, 2022
@maximlt maximlt deleted the interactive_operators_fixes branch August 5, 2022 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants