Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive: propagate max_rows #815

Merged
merged 6 commits into from
Aug 18, 2022
Merged

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Aug 3, 2022

Interactive has a max_rows parameter that should be passed down to the pn.pane.DataFrame object created when the output of a pipeline is a dataframe. This parameter was not passed down the pipeline, which is fixed by this PR.

@maximlt maximlt requested a review from hoxbro August 3, 2022 12:30
Copy link
Member

@hoxbro hoxbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect this to work:

import pandas as pd
import hvplot.pandas
import panel as pn

df = pd.DataFrame(range(1000), columns=["A"])
w = pn.widgets.IntSlider(end=1000, step=10)
dfi = df.interactive(max_rows=10)
dfi.loc[dfi.index > w]

But I get this error:

image

Am I doing something wrong?

@maximlt
Copy link
Member Author

maximlt commented Aug 5, 2022

Ush good catch!

@maximlt maximlt merged commit ba080fe into master Aug 18, 2022
@maximlt maximlt deleted the interactive_propagate_max_row branch August 18, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants