Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update core docstrings #863

Merged
merged 47 commits into from
Nov 23, 2022
Merged

Conversation

MarcSkovMadsen
Copy link
Collaborator

Improves the core docstrings

@MarcSkovMadsen MarcSkovMadsen marked this pull request as ready for review August 26, 2022 14:20
@maximlt
Copy link
Member

maximlt commented Oct 11, 2022

@MarcSkovMadsen is this ready to be reviewed?

@MarcSkovMadsen
Copy link
Collaborator Author

Yes. Thanks for asking. I think even more could be done, but it's like I can get it to 67% of perfect. The next contributor with a fresh perspective probably to 80%. And so on.

I really want the examples to be readable, copy-pastable and useful in the way that the data provided can easily to used to illustrate how the kind of plot works with datetime data instead of numeric data etc.

It also makes it much easier to have examples that quickly can be customized for example to address discourse questions or create reproducible examples for github.

@maximlt
Copy link
Member

maximlt commented Oct 13, 2022

Ok thanks! I think 67% perfect is already pretty damned good 👍 I'll take some time to review it shortly, after the tests pass.

@maximlt
Copy link
Member

maximlt commented Nov 23, 2022

Thanks a lot @MarcSkovMadsen for this, that's a massive amount of work that is going to change the experience of using hvPlot for a lot of users 👍 Despite my number of additional commits, each one of them were just making some very minor changes. This is going to be in a next release, hopefully tomorrow.

@maximlt maximlt merged commit 7d556ef into holoviz:master Nov 23, 2022
@MarcSkovMadsen
Copy link
Collaborator Author

For its also a big step. It gets the docs to 51% percent to perfect. Then there is 49% to go. I need more energy. Someone else needs to do an iteration too. And then it needs to be updated based on user feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants