-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update core docstrings #863
Update core docstrings #863
Conversation
…re/core-docstrings
…re/core-docstrings
@MarcSkovMadsen is this ready to be reviewed? |
Yes. Thanks for asking. I think even more could be done, but it's like I can get it to 67% of perfect. The next contributor with a fresh perspective probably to 80%. And so on. I really want the examples to be readable, copy-pastable and useful in the way that the data provided can easily to used to illustrate how the It also makes it much easier to have examples that quickly can be customized for example to address discourse questions or create reproducible examples for github. |
Ok thanks! I think 67% perfect is already pretty damned good 👍 I'll take some time to review it shortly, after the tests pass. |
Thanks a lot @MarcSkovMadsen for this, that's a massive amount of work that is going to change the experience of using hvPlot for a lot of users 👍 Despite my number of additional commits, each one of them were just making some very minor changes. This is going to be in a next release, hopefully tomorrow. |
For its also a big step. It gets the docs to 51% percent to perfect. Then there is 49% to go. I need more energy. Someone else needs to do an iteration too. And then it needs to be updated based on user feedback. |
Improves the
core
docstrings