Skip to content

Disable the urls test#867

Merged
maximlt merged 1 commit into
masterfrom
disable_url_test
Oct 11, 2022
Merged

Disable the urls test#867
maximlt merged 1 commit into
masterfrom
disable_url_test

Conversation

@maximlt

@maximlt maximlt commented Aug 27, 2022

Copy link
Copy Markdown
Member

I thought they would not be picked up as the file name is test_links.py while the test files in hvPlot are formatted as testthing.py, I was wrong, and it appeared this test isn't very robust and fails from time to time.

@MarcSkovMadsen

Copy link
Copy Markdown
Collaborator

When its made robust maybe it does not need to run for every combination of OS and Python version?

@maximlt

maximlt commented Sep 8, 2022

Copy link
Copy Markdown
Member Author

I think it should only run part of the docs build. I wouldn't like volunteers to find out their tests CI runs fail because of these tests (which will happen sooner or later) as it would be totally unrelated to their changes.

@maximlt
maximlt merged commit ea4e07f into master Oct 11, 2022
@maximlt
maximlt deleted the disable_url_test branch October 11, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants