Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for rioxarray rasterio and update tests #905

Merged
merged 5 commits into from
Oct 14, 2022

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Sep 14, 2022

Fixes #929

hvplot/converter.py Outdated Show resolved Hide resolved
@ianthomas23
Copy link
Member

I think the use of data.rio.crs is preferred as it checks a number of possible locations in the xarray for the CRS. It does however return an instance of rasterio.crs.CRS which we cannot pass to cartopy directly, so here I am converting to WKT first. This may not be ideal as it might give us various warnings, let's see what CI gives us.

An alternative to the to_wkt() is to add specific support in our CRS to cartopy for a rasterio.crs.CRS.

@hoxbro hoxbro requested a review from maximlt October 6, 2022 14:41
setup.py Outdated Show resolved Hide resolved
@maximlt
Copy link
Member

maximlt commented Oct 14, 2022

Great! Thanks a lot @hoxbro !

@maximlt maximlt merged commit 1b2db85 into holoviz:master Oct 14, 2022
@hoxbro hoxbro deleted the rioxarray branch October 14, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support rioxarray
3 participants