Add panel pin to ensure Bokeh <3 #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinning Panel instead of pinning more HoloViews allows us to preserve support of Python 3.6, at least for the time being. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIxes #970
With the release of Bokeh 3 users started to get Bokeh 3 when installing hvPlot, while it's not compatible with it.
This PR adds Panel as a runtime dependency, as it is actually required by the explorer. It also pins it to
>=0.11.0as this version of Panel is the first one that added an upper pin to Bokeh.Alternatively we could have pinned HoloViews to
>= 1.15.0as it pinned"panel >=0.13.1", however it's just been released 6 months ago. Previous releases of HoloViews pinned"panel >=0.9.5"which didn't have the upper pin for Bokeh.