Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove panel.serve template dependency on panel.holoviz.org #1176

Closed
MarcSkovMadsen opened this issue Mar 22, 2020 · 2 comments
Closed

Remove panel.serve template dependency on panel.holoviz.org #1176

MarcSkovMadsen opened this issue Mar 22, 2020 · 2 comments
Labels
Milestone

Comments

@MarcSkovMadsen
Copy link
Collaborator

@MarcSkovMadsen MarcSkovMadsen commented Mar 22, 2020

My Pain

When https://panel.holoviz.org/ is down (like now #1174)

image

the template used by panel.serve does not show the Panel logo

image

<img src="http://panel.pyviz.org/_static/logo_stacked.png" width="120">

Solution

Change the link of the image to a more robust cdn.

@MarcSkovMadsen MarcSkovMadsen changed the title Remove panel.serve template dependency on Remove panel.serve template dependency on panel.holoviz.org Mar 22, 2020
@philippjfr philippjfr added type: bug and removed TRIAGE labels Mar 22, 2020
@jbednar

This comment has been minimized.

Copy link
Member

@jbednar jbednar commented Mar 22, 2020

What if we changed the url to https://raw.githubusercontent.com/holoviz/panel/master/doc/_static/logo_stacked.png ? Is github's uptime sufficient? If not I'm not sure where else to host the image that would be more reliable.

@mattpap

This comment has been minimized.

Copy link
Collaborator

@mattpap mattpap commented Mar 22, 2020

I would just serve it as a static resource by panel.serve(). If the logo is small enough, it could be embedded as a data URL. Maybe those options were rejected earlier.

@philippjfr philippjfr added this to the v0.9.4 milestone Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants
You can’t perform that action at this time.