Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for jslinking HoloViews components #3165

Merged
merged 6 commits into from Apr 4, 2022
Merged

Conversation

philippjfr
Copy link
Member

Fixes #603

@philippjfr philippjfr changed the title Hv linking fixes Fixes for jslinking HoloViews components Feb 1, 2022
@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #3165 (f9c6443) into master (24e0c15) will increase coverage by 0.37%.
The diff coverage is 78.43%.

@@            Coverage Diff             @@
##           master    #3165      +/-   ##
==========================================
+ Coverage   82.98%   83.35%   +0.37%     
==========================================
  Files         192      196       +4     
  Lines       25500    26526    +1026     
==========================================
+ Hits        21161    22111     +950     
- Misses       4339     4415      +76     
Impacted Files Coverage Δ
panel/io/datamodel.py 43.75% <ø> (-4.17%) ⬇️
panel/pane/holoviews.py 79.24% <20.00%> (-0.63%) ⬇️
panel/links.py 85.02% <92.10%> (-0.60%) ⬇️
panel/reactive.py 77.24% <100.00%> (+0.95%) ⬆️
panel/tests/test_links.py 98.90% <100.00%> (ø)
panel/io/__init__.py 86.66% <0.00%> (-5.00%) ⬇️
panel/depends.py 80.51% <0.00%> (-3.31%) ⬇️
panel/io/profile.py 23.40% <0.00%> (-2.13%) ⬇️
panel/widgets/input.py 94.18% <0.00%> (-2.12%) ⬇️
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a264ad3...f9c6443. Read the comment docs.

@philippjfr philippjfr merged commit 340262d into master Apr 4, 2022
@philippjfr philippjfr deleted the hv_linking_fixes branch April 4, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jslink sometimes ignores key value pairs
1 participant