-
-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development version renders markdown differently that previous panel version #323
Comments
The code that generated the poster can be found here This should help reproduction. |
Thanks @Jacob-Barhak that will be helpful in tracking down what changed. |
Okay, I've tracked down the issue to a change in the bokeh CSS which is central to the layout refactor it seems we should raise this upstream but in the meantime we could simply override the |
Thanks Philipp,
You may want to also check if this CSS affects markdown table appearance.
The development panel version I used also generates tables that have no
borders.
Not sure what the default behavior should be, yet any type of difference
between cells in markdown tables would be better than the current version
that does not look nice by default as text seems to merge sometimes at cell
boundaries. If the CSS control that look, any type of divider will be
recommended.
So far, I was adding spaces to separate text.
Hopefully this can be fixed at the same time.
Jacob
…On Sat, Mar 23, 2019, 20:12 Philipp Rudiger ***@***.***> wrote:
Okay, I've tracked down the issue to a change in the bokeh CSS which is
central to the layout refactor it seems we should raise this upstream but
in the meantime we could simply override the ul tag CSS.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#323 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AB5Oa8V6hTxNczwZ4TBDzEK7aXMPa9Kzks5vZtEBgaJpZM4cCncK>
.
|
Okay I've made a PR with a number of CSS fixes, which I'll merge shortly. If you have other issues a PR to adjust the CSS defined in |
The development version 0.5.0a3 changed something in markdown. trying to generate the same code that generated this poster , displays different behavior.
First there are some slight differences in panel sizes - which is expected since some changes were made. However, the Markdown behavior is different.
When using enumeration or bullets, all bullets are now indented to the very left of the panel and nested bullets do no work - attached is an image. To the left you see the development panel version 0.5.0a3 and on the right you can see the stable panel 0.4.0. The code to generate this is slightly different, yet the markdown issue is clearly visible. I am using Windows 10 and the image was generated using edge and chrome.
You can clearly see the bullet and nested bullet issues. And note that bullets are almost invisible since they are pushed so much to the left that its hard to even see its a bullet - the bullet text also is not indented and can be mistaken for continuation of the text - so something seems wrong there. I was handling it so far by using text that look like:
Yet this is not a good solution for the long run.
Hopefully its sufficient information to locate the cause and fix it.
The text was updated successfully, but these errors were encountered: