Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development version renders markdown differently that previous panel version #323

Closed
Jacob-Barhak opened this issue Mar 22, 2019 · 5 comments

Comments

@Jacob-Barhak
Copy link
Contributor

The development version 0.5.0a3 changed something in markdown. trying to generate the same code that generated this poster , displays different behavior.

First there are some slight differences in panel sizes - which is expected since some changes were made. However, the Markdown behavior is different.

When using enumeration or bullets, all bullets are now indented to the very left of the panel and nested bullets do no work - attached is an image. To the left you see the development panel version 0.5.0a3 and on the right you can see the stable panel 0.4.0. The code to generate this is slightly different, yet the markdown issue is clearly visible. I am using Windows 10 and the image was generated using edge and chrome.

You can clearly see the bullet and nested bullet issues. And note that bullets are almost invisible since they are pushed so much to the left that its hard to even see its a bullet - the bullet text also is not indented and can be mistaken for continuation of the text - so something seems wrong there. I was handling it so far by using text that look like:

   - bullet text

Yet this is not a good solution for the long run.

PanelMarkdownDevelopmentVersionIssue

Hopefully its sufficient information to locate the cause and fix it.

@Jacob-Barhak
Copy link
Contributor Author

The code that generated the poster can be found here

This should help reproduction.

@philippjfr
Copy link
Member

Thanks @Jacob-Barhak that will be helpful in tracking down what changed.

@philippjfr
Copy link
Member

Okay, I've tracked down the issue to a change in the bokeh CSS which is central to the layout refactor it seems we should raise this upstream but in the meantime we could simply override the ul tag CSS.

@Jacob-Barhak
Copy link
Contributor Author

Jacob-Barhak commented Mar 24, 2019 via email

@philippjfr
Copy link
Member

Okay I've made a PR with a number of CSS fixes, which I'll merge shortly. If you have other issues a PR to adjust the CSS defined in Markdown._css_style would be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants