Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DeckGL pane [doc-build] #1019

Merged
merged 17 commits into from Jan 28, 2020
Merged

Add DeckGL pane [doc-build] #1019

merged 17 commits into from Jan 28, 2020

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Jan 27, 2020

Supersedes #960

Fixes #957

@philippjfr philippjfr mentioned this pull request Jan 27, 2020
@philippjfr philippjfr changed the title Add pydeck Add DeckGL pane Jan 28, 2020
@philippjfr philippjfr changed the title Add DeckGL pane Add DeckGL pane [doc-build] Jan 28, 2020
@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Jan 28, 2020

@MarcSkovMadsen Thanks so much for getting this started! Getting this to work reliably in Jupyter notebooks and JupyterLab was a huge pain but I've worked out a solution. In JupyterLab (and on the server) we load the individual dependencies while in Jupyter notebooks we load the pydeck jupyter-widget bundle (as you were doing). The former is more efficient overall and really this is kind of hacky but I hope eventually we can have smaller bundles which consistently load the components using npm or get a better mechanism for loading the JS dependencies lazily. For now I'm very happy to have this in 0.8! This should be the last code PR to go in and I should be ready to release tomorrow.

@philippjfr philippjfr merged commit 097dd8b into master Jan 28, 2020
0 of 2 checks passed
@codecov
Copy link

@codecov codecov bot commented Jan 28, 2020

Codecov Report

Merging #1019 into master will increase coverage by 0.19%.
The diff coverage is 22.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1019      +/-   ##
==========================================
+ Coverage    85.8%   85.99%   +0.19%     
==========================================
  Files         105      105              
  Lines       12000    11891     -109     
==========================================
- Hits        10296    10226      -70     
+ Misses       1704     1665      -39
Impacted Files Coverage Δ
panel/config.py 52.43% <0%> (ø) ⬆️
panel/pipeline.py 88.57% <0%> (ø) ⬆️
panel/tests/pane/test_holoviews.py 99.46% <0%> (ø) ⬆️
panel/tests/test_template.py 95.74% <0%> (ø) ⬆️
panel/tests/util.py 83.6% <0%> (ø) ⬆️
panel/widgets/tables.py 77.86% <0%> (ø) ⬆️
panel/widgets/select.py 94.3% <0%> (ø) ⬆️
panel/pane/vtk/vtk.py 53.92% <0%> (ø) ⬆️
panel/cli.py 42.18% <0%> (ø) ⬆️
panel/interact.py 76.07% <0%> (-2.54%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f323b2b...226910a. Read the comment docs.

@MarcSkovMadsen
Copy link
Collaborator

@MarcSkovMadsen MarcSkovMadsen commented Jan 28, 2020

Hi @philippjfr

I'm so impressed. I could have spent a week on this. Don't know how you know how to do all these things :-)

One thing that might be interesting is that I have a more advanced example of using the DeckGL pane. I will create a new pull request to include that.

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Jan 28, 2020

I'm so impressed. I could have spent a week on this. Don't know how you know how to do all these things :-)

Ha, don't put yourself down, you got things 90% there, I just did all the tedium of making things work across across different environments (honestly I wanted to pull my hair out on this) and updating it to the new build infrastructure.

One thing that might be interesting is that I have a more advanced example of using the DeckGL pane. I will create a new pull request to include that.

Yes, we need to get the gallery more populated somehow. At some point soon I'll ask people to contribute their examples back to the gallery. A more complex DeckGL example would be hugely appreciated.

@jbednar
Copy link
Member

@jbednar jbednar commented Jan 28, 2020

A more complex DeckGL example would be hugely appreciated.

More complex examples should probably be part of examples.pyviz.org, not Panel itself, so that they can have their own separate pinned environment rather than necessarily being updated during every Panel release...

@philippjfr philippjfr deleted the add-pydeck branch Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants