Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made signature of show() match that of servable() #1095

Open
wants to merge 1 commit into
base: master
from
Open

Conversation

@jbednar
Copy link
Member

jbednar commented Feb 13, 2020

Right now, a notebook can have .servable('Title'), but it has to have .show(title='Title') with the keyword specified. I very often switch between .show and .servable when debugging, and this difference makes doing so awkward. Note that if someone has previously used "port" as a positional argument, this change will not be backwards compatible. So I can understand if it's decided not to merge this, but I thought it was worth proposing before the number of Panel users got so high that this behavior could never be changed.

@philippjfr philippjfr added this to the v0.9.0 milestone Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.