Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Player widget #110

Merged
merged 6 commits into from Oct 24, 2018
Merged

Implement Player widget #110

merged 6 commits into from Oct 24, 2018

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Oct 19, 2018

This PR adds a custom bokeh model which replicates the "scrubber" style widget from HoloViews.

Unlike the HoloViews version this one is fully dynamic and the state can be controlled from Python.

screen shot 2018-10-19 at 12 41 37 pm

Also implements support for using the widget on HoloViews plots:

screen shot 2018-10-19 at 1 05 50 pm

@codecov-io
Copy link

@codecov-io codecov-io commented Oct 24, 2018

Codecov Report

Merging #110 into master will decrease coverage by 0.08%.
The diff coverage is 84%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #110      +/-   ##
========================================
- Coverage   90.08%    90%   -0.09%     
========================================
  Files          26     27       +1     
  Lines        4024   4061      +37     
========================================
+ Hits         3625   3655      +30     
- Misses        399    406       +7
Impacted Files Coverage Δ
panel/widgets.py 97.6% <100%> (+0.05%) ⬆️
panel/viewable.py 70.31% <100%> (ø) ⬆️
panel/tests/test_holoviews.py 98.99% <100%> (ø) ⬆️
panel/models/widgets.py 100% <100%> (ø)
panel/holoviews.py 83.22% <68%> (-2.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00deada...151f979. Read the comment docs.

@philippjfr philippjfr merged commit b352396 into master Oct 24, 2018
2 checks passed
@philippjfr philippjfr deleted the player_widget branch Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants