Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Bokeh 2 DatePicker #1187

Merged
merged 3 commits into from
Mar 25, 2020
Merged

Compatibility with Bokeh 2 DatePicker #1187

merged 3 commits into from
Mar 25, 2020

Conversation

hyamanieu
Copy link
Collaborator

See bokeh/bokeh#9509 , date is in ISO format.

@philippjfr
Copy link
Member

Thanks, we'll also have to update the existing tests which mocks a change in the date but still uses the old date format

date_picker._comm_change({'value': 'Mon Sep 03 2018'})

@codecov
Copy link

codecov bot commented Mar 25, 2020

Codecov Report

Merging #1187 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1187   +/-   ##
=======================================
  Coverage   87.79%   87.79%           
=======================================
  Files         105      105           
  Lines       12598    12598           
=======================================
  Hits        11061    11061           
  Misses       1537     1537           
Impacted Files Coverage Δ
panel/tests/widgets/test_input.py 100.00% <100.00%> (ø)
panel/widgets/input.py 96.12% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8c0c20...122678f. Read the comment docs.

@philippjfr
Copy link
Member

Thanks again! Hugely appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants