New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pn.panel and ensure all Panes have layout attribute #126
Conversation
Codecov Report
@@ Coverage Diff @@
## master #126 +/- ##
==========================================
- Coverage 90% 89.75% -0.25%
==========================================
Files 27 27
Lines 4061 4023 -38
==========================================
- Hits 3655 3611 -44
- Misses 406 412 +6
Continue to review full report at Codecov.
|
panel/layout.py
Outdated
@@ -313,3 +320,6 @@ def _get_model(self, doc, root=None, parent=None, comm=None): | |||
model = self._bokeh_model(**self._init_properties()) | |||
self._link_params(model, ['width', 'height'], doc, root, comm) | |||
return model | |||
|
|||
|
|||
PaneBase._default_layout = Row |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this not be a public class Parameter? Seems like something one could legitimately want to customize.
Always prefer if you warn me about making edits to a branch I'm actively working on. You can now also leave suggested edits directly in the GitHub, which let's me apply the changes when I'm ready. |
@jlstevens, consider code like this:
To me |
examples/user_guide/Panes.ipynb
Outdated
"cell_type": "markdown", | ||
"metadata": {}, | ||
"source": [ | ||
"One thing to note is that since a ``Pane`` may define multiple views, when working with an explicitly constructed ``Pane`` care should be taken to compose the component of the ``Pane.layout`` manually." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the components?
@jbednar Any objections to merging this soon? |
@jbednar Please test this extensively.