Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently clean up state after exceptions #128

Merged
merged 2 commits into from Oct 26, 2018
Merged

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Oct 26, 2018

There were still cases where Exceptions would break a panel irrecoverably.

@codecov-io
Copy link

@codecov-io codecov-io commented Oct 26, 2018

Codecov Report

Merging #128 into master will increase coverage by 0.24%.
The diff coverage is 55.55%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #128      +/-   ##
========================================
+ Coverage   89.76%    90%   +0.24%     
========================================
  Files          27     27              
  Lines        4025   4124      +99     
========================================
+ Hits         3613   3712      +99     
  Misses        412    412
Impacted Files Coverage Δ
panel/interact.py 71.7% <0%> (ø) ⬆️
panel/param.py 94.17% <50%> (+3.9%) ⬆️
panel/viewable.py 69.19% <57.14%> (-1.13%) ⬇️
panel/pane.py 81.53% <71.42%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5eb787b...e0d1ed9. Read the comment docs.

@philippjfr philippjfr merged commit afabc17 into master Oct 26, 2018
2 checks passed
@philippjfr philippjfr deleted the exception_handling2 branch Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants